aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/attribute_methods
diff options
context:
space:
mode:
authorJon Leighton <j@jonathanleighton.com>2012-01-31 08:50:36 +0000
committerJon Leighton <j@jonathanleighton.com>2012-01-31 08:50:36 +0000
commitb2955edcea63e3daa347dc4e05b9abd380176ac8 (patch)
treee97e7dc4ca132e4b289d32c2f6d5f38112a2295e /activerecord/lib/active_record/attribute_methods
parent0bfc504d9ced49d50afa7a8b19680ae7f42c2b24 (diff)
downloadrails-b2955edcea63e3daa347dc4e05b9abd380176ac8.tar.gz
rails-b2955edcea63e3daa347dc4e05b9abd380176ac8.tar.bz2
rails-b2955edcea63e3daa347dc4e05b9abd380176ac8.zip
Allow writing unknown attributes, but with a deprecation warning. Closes #4583.
Diffstat (limited to 'activerecord/lib/active_record/attribute_methods')
-rw-r--r--activerecord/lib/active_record/attribute_methods/write.rb11
1 files changed, 7 insertions, 4 deletions
diff --git a/activerecord/lib/active_record/attribute_methods/write.rb b/activerecord/lib/active_record/attribute_methods/write.rb
index fde55b95da..8c6fa90a28 100644
--- a/activerecord/lib/active_record/attribute_methods/write.rb
+++ b/activerecord/lib/active_record/attribute_methods/write.rb
@@ -28,11 +28,14 @@ module ActiveRecord
@attributes_cache.delete(attr_name)
column = column_for_attribute(attr_name)
- if column || @attributes.has_key?(attr_name)
- @attributes[attr_name] = type_cast_attribute_for_write(column, value)
- else
- raise ActiveModel::MissingAttributeError, "can't write unknown attribute `#{attr_name}'"
+ unless column || @attributes.has_key?(attr_name)
+ ActiveSupport::Deprecation.warn(
+ "You're trying to create an attribute `#{attr_name}'. Writing arbitrary " \
+ "attributes on a model is deprecated. Please just use `attr_writer` etc."
+ )
end
+
+ @attributes[attr_name] = type_cast_attribute_for_write(column, value)
end
alias_method :raw_write_attribute, :write_attribute