diff options
| author | Xavier Noria <fxn@hashref.com> | 2016-08-08 01:05:28 +0200 |
|---|---|---|
| committer | Xavier Noria <fxn@hashref.com> | 2016-08-08 01:12:38 +0200 |
| commit | a9dc45459abcd9437085f4dd0aa3c9d0e64e062f (patch) | |
| tree | fe160bcd744ad3dffbe901a4b44df2c2343130de /activerecord/lib/active_record/associations | |
| parent | b45c9ca9b6571108242c1dfc3d3e160f56baf025 (diff) | |
| download | rails-a9dc45459abcd9437085f4dd0aa3c9d0e64e062f.tar.gz rails-a9dc45459abcd9437085f4dd0aa3c9d0e64e062f.tar.bz2 rails-a9dc45459abcd9437085f4dd0aa3c9d0e64e062f.zip | |
code gardening: removes redundant selfs
A few have been left for aesthetic reasons, but have made a pass
and removed most of them.
Note that if the method `foo` returns an array, `foo << 1`
is a regular push, nothing to do with assignments, so
no self required.
Diffstat (limited to 'activerecord/lib/active_record/associations')
| -rw-r--r-- | activerecord/lib/active_record/associations/has_one_association.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/associations/has_one_association.rb b/activerecord/lib/active_record/associations/has_one_association.rb index 08a4611013..5ea9577301 100644 --- a/activerecord/lib/active_record/associations/has_one_association.rb +++ b/activerecord/lib/active_record/associations/has_one_association.rb @@ -32,7 +32,7 @@ module ActiveRecord raise_on_type_mismatch!(record) if record load_target - return self.target if !(target || record) + return target unless target || record assigning_another_record = target != record if assigning_another_record || record.changed? |