Revert "Remove `counter_cache_target` which is no longer called"

This reverts commit 376ffe0ea2e59dc51461122210729c05a10fb443.

Since 38fae1f, `association.increment_counters` is called without
inflated parent target if inverse_of is disabled.
In that case, that commit would cause extra queries to inflate parent.

1 files changed, 10 insertions, 1 deletions

diff --git a/activerecord/lib/active_record/associations/belongs_to_association.rb b/activerecord/lib/active_record/associations/belongs_to_association.rb
index 11a89366aa..544aec5e8b 100644
--- a/activerecord/lib/active_record/associations/belongs_to_association.rb
+++ b/activerecord/lib/active_record/associations/belongs_to_association.rb
@@ -61,7 +61,11 @@ module ActiveRecord
 
         def update_counters(by)
           if require_counter_update? && foreign_key_present?
-            reader.increment!(reflection.counter_cache_column, by, touch: reflection.options[:touch])
+            if target && !stale_target?
+              target.increment!(reflection.counter_cache_column, by, touch: reflection.options[:touch])
+            else
+              counter_cache_target.update_counters(reflection.counter_cache_column => by, touch: reflection.options[:touch])
+            end
           end
         end
 
@@ -92,6 +96,11 @@ module ActiveRecord
           inverse && inverse.has_one?
         end
 
+        def counter_cache_target
+          primary_key = reflection.association_primary_key(klass)
+          klass.unscoped.where!(primary_key => owner._read_attribute(reflection.foreign_key))
+        end
+
         def stale_state
           result = owner._read_attribute(reflection.foreign_key) { |n| owner.send(:missing_attribute, n, caller) }
           result && result.to_s