aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/associations/join_dependency/join_base.rb
diff options
context:
space:
mode:
authorSean Griffin <sean@thoughtbot.com>2014-06-21 11:31:57 -0600
committerSean Griffin <sean@thoughtbot.com>2014-06-22 09:00:15 -0600
commitc083ce6dd283303aaf0224943dcc759e52536adc (patch)
treefafb2643e268bc13bf4f5ab1964a0dcb5dbcd062 /activerecord/lib/active_record/associations/join_dependency/join_base.rb
parent281c92a346fe3575c417003b63d66f7f3a0a259c (diff)
downloadrails-c083ce6dd283303aaf0224943dcc759e52536adc.tar.gz
rails-c083ce6dd283303aaf0224943dcc759e52536adc.tar.bz2
rails-c083ce6dd283303aaf0224943dcc759e52536adc.zip
Encapsulate knowledge of type objects on `ActiveRecord::Result`
Attempting to reduce the number of places that care about the details of how type casting occurs. We remove the type casting of the primary key in `JoinDependecy`, rather than encapsulating it. It was originally added for consistency with https://github.com/rails/rails/commit/40898c8c19fa04442fc5f8fb5daf3a8bdb9a1e03#diff-06059df8d3dee3101718fb2c01151ad0R211, but that conditional was later removed in https://github.com/rails/rails/commit/d7ddaa530fd1b94e22d745cbaf2e8a5a34ee9734. What is important is that the same row twice will have the same value for the primary key, which it will.
Diffstat (limited to 'activerecord/lib/active_record/associations/join_dependency/join_base.rb')
0 files changed, 0 insertions, 0 deletions