diff options
| author | Mehmet Emin İNAÇ <mehmetemininac@gmail.com> | 2015-04-14 22:50:36 +0300 |
|---|---|---|
| committer | Mehmet Emin İNAÇ <mehmetemininac@gmail.com> | 2016-02-13 17:21:25 +0200 |
| commit | 9991f14fced25dac3699b473a05cc7a196f9220e (patch) | |
| tree | daace2e77f5c88e29f7e8fda85cc9cbd4b6fdcb6 /activerecord/lib/active_record/associations/has_many_through_association.rb | |
| parent | 7ee2002008eb7bd4546f556670f5332f06901a0d (diff) | |
| download | rails-9991f14fced25dac3699b473a05cc7a196f9220e.tar.gz rails-9991f14fced25dac3699b473a05cc7a196f9220e.tar.bz2 rails-9991f14fced25dac3699b473a05cc7a196f9220e.zip | |
Fix for has_and_belongs_to_many & has_many_through associations while partial_writes is false
This will fix #19663
Also with this fix, active record does not fire unnecassary update queries while partial_writes is true
Diffstat (limited to 'activerecord/lib/active_record/associations/has_many_through_association.rb')
| -rw-r--r-- | activerecord/lib/active_record/associations/has_many_through_association.rb | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/associations/has_many_through_association.rb b/activerecord/lib/active_record/associations/has_many_through_association.rb index 36fc381343..7ddb96db13 100644 --- a/activerecord/lib/active_record/associations/has_many_through_association.rb +++ b/activerecord/lib/active_record/associations/has_many_through_association.rb @@ -86,7 +86,10 @@ module ActiveRecord end def save_through_record(record) - build_through_record(record).save! + association = build_through_record(record) + if association.changed? + association.save! + end ensure @through_records.delete(record.object_id) end |