diff options
| author | Lauro Caetano <laurocaetano1@gmail.com> | 2014-04-07 16:01:17 -0300 |
|---|---|---|
| committer | Lauro Caetano <laurocaetano1@gmail.com> | 2014-04-07 16:23:34 -0300 |
| commit | 6c311e0b7538e8c55797aa889fdf66780ab283a4 (patch) | |
| tree | cfaf86edc8aea5e4919963768a8f191359d981d6 /activerecord/lib/active_record/associations/collection_association.rb | |
| parent | 6bbbe0b6513d7452cba43680f0da8362b98d4ca5 (diff) | |
| download | rails-6c311e0b7538e8c55797aa889fdf66780ab283a4.tar.gz rails-6c311e0b7538e8c55797aa889fdf66780ab283a4.tar.bz2 rails-6c311e0b7538e8c55797aa889fdf66780ab283a4.zip | |
Build the reverse_order on its proper method.
The reverse_order method was using a flag to control if the order should
be reversed or not. Instead of using this variable just build the reverse order
inside its proper method.
This implementation was leading to an unexpected behavior when using
reverse_order and then applying reorder(nil).
Example:
Before
Post.order(:name).reverse_order.reorder(nil)
# => SELECT "posts".* FROM "posts" ORDER BY "posts"."id" DESC
After
Post.order(:name).reverse_order.reorder(nil)
# => SELECT "posts".* FROM "posts"
Diffstat (limited to 'activerecord/lib/active_record/associations/collection_association.rb')
0 files changed, 0 insertions, 0 deletions