diff options
| author | Sean Griffin <sean@thoughtbot.com> | 2015-04-18 10:44:26 -0400 |
|---|---|---|
| committer | Sean Griffin <sean@thoughtbot.com> | 2015-04-18 10:47:04 -0400 |
| commit | d849f42b4ecf687ed5350f5a2402fb795aa33aac (patch) | |
| tree | 1b65d8e0df921dc78693120c80d609d53c4fc100 /activerecord/CHANGELOG.md | |
| parent | 228559eab8e50dd52e1f07841a288ed39c84ff4e (diff) | |
| download | rails-d849f42b4ecf687ed5350f5a2402fb795aa33aac.tar.gz rails-d849f42b4ecf687ed5350f5a2402fb795aa33aac.tar.bz2 rails-d849f42b4ecf687ed5350f5a2402fb795aa33aac.zip | |
Autosave existing records on HMT associations when the parent is new
To me it seems like this should only be the case if `autosave: true` is
set on the association. However, when implemented that way, it caused
issues with has many associations, where we have explicit tests stating
that child records are updated when the parent is new, even if autosave
is not set (presumably to update the parent id, but other changed
attributes would be persisted as well).
It's quirky, but at least we should be consistently quirky. This
constitutes a minor but subtle change in behavior, and therefore should
not be backported to 4.2 and earlier.
Fixes #19782
Diffstat (limited to 'activerecord/CHANGELOG.md')
| -rw-r--r-- | activerecord/CHANGELOG.md | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 904ac5c26a..58ebd5d9ed 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,10 @@ +* Autosave existing records on a has many through association when the parent + is new. + + Fixes #19782. + + *Sean Griffin* + * Fixed a bug where uniqueness validations would error on out of range values, even if an validation should have prevented it from hitting the database. |