diff options
| author | Yves Senn <yves.senn@gmail.com> | 2013-03-12 10:52:25 +0100 |
|---|---|---|
| committer | Yves Senn <yves.senn@gmail.com> | 2013-03-15 14:15:47 +0100 |
| commit | cd87c85ef05e47f6ea1ce7422ae033fe6d82b030 (patch) | |
| tree | d4a74669f3f5a9dd8900b688e4e00481c0a8b1e9 /activerecord/CHANGELOG.md | |
| parent | a1bb6c8b06db83546179175b9b2dde7912c86f9b (diff) | |
| download | rails-cd87c85ef05e47f6ea1ce7422ae033fe6d82b030.tar.gz rails-cd87c85ef05e47f6ea1ce7422ae033fe6d82b030.tar.bz2 rails-cd87c85ef05e47f6ea1ce7422ae033fe6d82b030.zip | |
Deprecate the `:distinct` option for `Relation#count`.
We moved more and more away from passing options to finder / calculation
methods. The `:distinct` option in `#count` was one of the remaining places.
Since we can now combine `Relation#distinct` with `Relation#count` the option
is no longer necessary and can be deprecated.
Diffstat (limited to 'activerecord/CHANGELOG.md')
| -rw-r--r-- | activerecord/CHANGELOG.md | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 37be191e0c..6affb2aada 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,5 +1,18 @@ ## Rails 4.0.0 (unreleased) ## +* The `:distinct` option for `Relation#count` is deprecated. You + should use `Relation#distinct` instead. + + Example: + + # Before + Post.select(:author_name).count(distinct: true) + + # After + Post.select(:author_name).distinct.count + + *Yves Senn* + * Rename `Relation#uniq` to `Relation#distinct`. `#uniq` is still available as an alias but we encourage to use `#distinct` instead. Also `Relation#uniq_value` is aliased to `Relation#distinct_value`, |