diff options
| author | Arthur Neves <arthurnn@gmail.com> | 2014-01-29 21:17:10 -0500 |
|---|---|---|
| committer | Arthur Neves <arthurnn@gmail.com> | 2014-01-30 14:06:40 -0500 |
| commit | b7fcad8ff04411a8d00f85094b172b6b99402190 (patch) | |
| tree | ee2715f365812a464057bb64faa0dca3c587bbb2 /activerecord/CHANGELOG.md | |
| parent | db5d6bf74f3f6423e56120198685b8665e59616e (diff) | |
| download | rails-b7fcad8ff04411a8d00f85094b172b6b99402190.tar.gz rails-b7fcad8ff04411a8d00f85094b172b6b99402190.tar.bz2 rails-b7fcad8ff04411a8d00f85094b172b6b99402190.zip | |
Fix regression on `.select_*` methods.
This was a common pattern:
```
query = author.posts.select(:title)
connection.select_one(query)
```
However `.select` returns a ActiveRecord::AssociationRelation, which has
the bind information, so we can use that to get the right sql query.
Also fix select_rows on postgress and sqlite3 that were not using the binds
[fixes #7538]
[fixes #12017]
[related #13731]
[related #12056]
Diffstat (limited to 'activerecord/CHANGELOG.md')
| -rw-r--r-- | activerecord/CHANGELOG.md | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 7df4720ea5..a6400a169b 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,11 @@ +* Fix regressions on `select_*` methods. + When `select_*` methods receive a `Relation` object, they should be able to get the arel/binds from it. + Also fix regressions on select_rows that was ignoring the binds. + + Fixes #7538, #12017, #13731, #12056. + + *arthurnn* + * Active Record objects can now be correctly dumped, loaded and dumped again without issues. Previously, if you did `YAML.dump`, `YAML.load` and then `YAML.dump` again |