diff options
| author | Miklos Fazekas <mfazekas@szemafor.com> | 2014-10-02 10:02:30 +0200 |
|---|---|---|
| committer | Miklos Fazekas <mfazekas@szemafor.com> | 2015-02-04 15:42:14 +0100 |
| commit | 5f6370a81bd013b801f3e4842ffd466d756d127d (patch) | |
| tree | f4901908bbb0331a816027251e6394a0c53653b2 /activerecord/CHANGELOG.md | |
| parent | 1405c7a2cb3539880ebd82c287040b55d289a427 (diff) | |
| download | rails-5f6370a81bd013b801f3e4842ffd466d756d127d.tar.gz rails-5f6370a81bd013b801f3e4842ffd466d756d127d.tar.bz2 rails-5f6370a81bd013b801f3e4842ffd466d756d127d.zip | |
Always reset changed attributes in becomes
When ```becomes``` changes @attributes it should also change
@changed_attributes. Otherwise we'll experience a kind of split head situation
where attributes are coming from ```self```, but changed_attributes is coming
from ```klass.new```. This affects the inheritance_colmn as it's changed by new
for example.
Fixes #16881
Diffstat (limited to 'activerecord/CHANGELOG.md')
| -rw-r--r-- | activerecord/CHANGELOG.md | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 0105dfa78c..3bfaa59f06 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,9 @@ +* Fixed ActiveRecord::Relation#becomes! and changed_attributes issues for type column + + Fixes #17139. + + *Miklos Fazekas* + * Fixed several edge cases which could result in a counter cache updating twice or not updating at all for `has_many` and `has_many :through`. |