diff options
author | Carlos Antonio da Silva <carlosantoniodasilva@gmail.com> | 2014-01-31 01:41:24 -0800 |
---|---|---|
committer | Carlos Antonio da Silva <carlosantoniodasilva@gmail.com> | 2014-01-31 01:41:24 -0800 |
commit | 5df52961f7dad10af5d4341df5f8a62c4634b699 (patch) | |
tree | 057dda816d6caad517ef58cdd8cb2c8ee0abf665 /activerecord/CHANGELOG.md | |
parent | 530cab328ef3f2a29767911b3a17574198cd7510 (diff) | |
parent | 4506dd2f07be824fd7e0eb6165c29994aeb1bfcd (diff) | |
download | rails-5df52961f7dad10af5d4341df5f8a62c4634b699.tar.gz rails-5df52961f7dad10af5d4341df5f8a62c4634b699.tar.bz2 rails-5df52961f7dad10af5d4341df5f8a62c4634b699.zip |
Merge pull request #13896 from laurocaetano/dangerous_association_names
Associations now raises `ArgumentError` on name conflicts. Closes #13217.
Diffstat (limited to 'activerecord/CHANGELOG.md')
-rw-r--r-- | activerecord/CHANGELOG.md | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index a6400a169b..f3322dd7f6 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,19 @@ +* Associations now raise `ArgumentError` on name conflicts. + + Dangerous association names conflicts include instance or class methods already + defined by `ActiveRecord::Base`. + + Example: + + class Car < ActiveRecord::Base + has_many :errors + end + # Will raise ArgumentError. + + Fixes #13217. + + *Lauro Caetano* + * Fix regressions on `select_*` methods. When `select_*` methods receive a `Relation` object, they should be able to get the arel/binds from it. Also fix regressions on select_rows that was ignoring the binds. |