diff options
| author | Guilherme Goettems Schneider <guigs81@gmail.com> | 2019-06-03 08:05:36 -0300 |
|---|---|---|
| committer | Guilherme Goettems Schneider <guigs81@gmail.com> | 2019-06-03 08:35:36 -0300 |
| commit | 49f31043be571381fd66dbc22b123d5625af64de (patch) | |
| tree | aeecb67c6d1360597fa5192abb35ec30293f1e18 /activerecord/CHANGELOG.md | |
| parent | 5f2bc3a6a00a2277481de7241f7a2066e886b84d (diff) | |
| download | rails-49f31043be571381fd66dbc22b123d5625af64de.tar.gz rails-49f31043be571381fd66dbc22b123d5625af64de.tar.bz2 rails-49f31043be571381fd66dbc22b123d5625af64de.zip | |
Fix invalid schema dump when primary key column has a comment
Before this fix it would either generate an invalid schema, passing `comment` option twice to `create_table`, or it move the comment from primary key column to the table if table had no comment when the dump was generated.
The situation now is that a comment on primary key will be ignored (not present on schema).
Fixes #29966
Diffstat (limited to 'activerecord/CHANGELOG.md')
| -rw-r--r-- | activerecord/CHANGELOG.md | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 2b5fc1c2f8..6f08b1b8fe 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,9 @@ +* Fix invalid schema when primary key column has a comment + + Fixes #29966 + + *Guilherme Goettems Schneider* + * Fix table comment also being applied to the primary key column *Guilherme Goettems Schneider* |