aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/CHANGELOG.md
diff options
context:
space:
mode:
authorawilliams <pwnfactory@gmail.com>2013-06-26 14:47:50 +0200
committerawilliams <pwnfactory@gmail.com>2013-07-16 12:14:09 +0200
commit41bd94b7ef0db484268b8c81de528aedad5ae08d (patch)
tree0950817d31ee121bd6ca1eb019a0b1a4650d1593 /activerecord/CHANGELOG.md
parent754a373e301d2df0b12a11083405252722bc8366 (diff)
downloadrails-41bd94b7ef0db484268b8c81de528aedad5ae08d.tar.gz
rails-41bd94b7ef0db484268b8c81de528aedad5ae08d.tar.bz2
rails-41bd94b7ef0db484268b8c81de528aedad5ae08d.zip
Unifies mysql and mysql2 casting of booleans
Using the mysql2 adapter, boolean values were sometimes being incorrectly cast to 't' or 'f'. This changes the cast to match the mysql adapter behavior, ie 1 and 0.
Diffstat (limited to 'activerecord/CHANGELOG.md')
-rw-r--r--activerecord/CHANGELOG.md22
1 files changed, 22 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md
index 8e262b5fd7..8667f40406 100644
--- a/activerecord/CHANGELOG.md
+++ b/activerecord/CHANGELOG.md
@@ -1,3 +1,25 @@
+* Fix bug when using Mysql2 adapter where in some cases, boolean values were
+ being output in sql as `t` or `f` instead of `1` or `0`. Example:
+
+ class Model < ActiveRecord::Base
+ validates_uniqueness_of :boolean_col
+ end
+ Model.first.valid?
+
+ Previously generated sql:
+
+ SELECT 1 AS one FROM `models` WHERE
+ `models`.`boolean_col` = BINARY 'f' LIMIT 1
+
+ With fix:
+
+ SELECT 1 AS one FROM `models` WHERE
+ `models`.`boolean_col` = BINARY 0 LIMIT 1
+
+ Fixes: #11119
+
+ *Adam Williams*
+
* `change_column` for PostgreSQL adapter respects the `:array` option.
*Yves Senn*