diff options
| author | Larry Reid <lcreid@jadesystems.ca> | 2018-07-16 10:44:55 -0700 |
|---|---|---|
| committer | Larry Reid <lcreid@jadesystems.ca> | 2018-07-23 14:53:27 -0700 |
| commit | 332e7601a98ebff6a7494a556c7fe97c5691f085 (patch) | |
| tree | dd60a40250979168ca972db33a189774dc5e75e5 /activerecord/CHANGELOG.md | |
| parent | bd139a59405044c27bf367cde671e4bdbf7ccb57 (diff) | |
| download | rails-332e7601a98ebff6a7494a556c7fe97c5691f085.tar.gz rails-332e7601a98ebff6a7494a556c7fe97c5691f085.tar.bz2 rails-332e7601a98ebff6a7494a556c7fe97c5691f085.zip | |
Fix circular `autosave: true`
Use a variable local to the `save_collection_association` method in
`activerecord/lib/active_record/autosave_association.rb`, instead of an
instance variable.
Prior to this PR, when there was a circular series of `autosave: true`
associations, the callback for a `has_many` association was run while
another instance of the same callback on the same association hadn't
finished running. When control returned to the first instance of the
callback, the instance variable had changed, and subsequent associated
records weren't saved correctly. Specifically, the ID field for the
`belongs_to` corresponding to the `has_many` was `nil`.
Remove unnecessary test and comments.
Fixes #28080.
Diffstat (limited to 'activerecord/CHANGELOG.md')
| -rw-r--r-- | activerecord/CHANGELOG.md | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 456f569718..b74ad35a92 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,20 @@ +* Fix circular `autosave: true` + + Use a variable local to the `save_collection_association` method in + `activerecord/lib/active_record/autosave_association.rb`, instead of an + instance variable. + + Prior to this PR, when there was a circular series of `autosave: true` + associations, the callback for a `has_many` association was run while + another instance of the same callback on the same association hadn't + finished running. When control returned to the first instance of the + callback, the instance variable had changed, and subsequent associated + records weren't saved correctly. Specifically, the ID field for the + `belongs_to` corresponding to the `has_many` was `nil`. + + Fixes #28080. + + *Larry Reid* * Don't impose primary key order if limit() has already been supplied. Fixes #23607 |