diff options
| author | Ryuta Kamizono <kamipo@gmail.com> | 2019-03-11 01:30:40 +0900 |
|---|---|---|
| committer | Ryuta Kamizono <kamipo@gmail.com> | 2019-03-11 01:35:46 +0900 |
| commit | 260a3c65122a726eea20828d4909e15502751c39 (patch) | |
| tree | c8db53f063248e33d4377cee9e1721d8f697e0e3 /activerecord/CHANGELOG.md | |
| parent | b75d6ea5d35d61c60f2675ed956c51e71d2b07ad (diff) | |
| parent | 81bc621ed01637e8305fb53c9e504b1cc46c102f (diff) | |
| download | rails-260a3c65122a726eea20828d4909e15502751c39.tar.gz rails-260a3c65122a726eea20828d4909e15502751c39.tar.bz2 rails-260a3c65122a726eea20828d4909e15502751c39.zip | |
Merge pull request #35320 from kamille-gz/fix_query_method_when_given_Date_data_type
Fix ActiveRecord query attribute method when given value does't respond to to_i method
Diffstat (limited to 'activerecord/CHANGELOG.md')
| -rw-r--r-- | activerecord/CHANGELOG.md | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index c0ef3cbe7c..2d260f2bf5 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,17 @@ +* Fix query attribute method on user-defined attribute to be aware of typecasted value. + + For example, the following code no longer return false as casted non-empty string: + + ``` + class Post < ActiveRecord::Base + attribute :user_defined_text, :text + end + + Post.new(user_defined_text: "false").user_defined_text? # => true + ``` + + *Yuji Kamijima* + * Quote empty ranges like other empty enumerables. *Patrick Rebsch* |