diff options
| author | Yoshiyuki Kinjo <yskkin@gmail.com> | 2019-04-14 20:31:05 +0900 |
|---|---|---|
| committer | Yoshiyuki Kinjo <yskkin@gmail.com> | 2019-04-15 08:43:22 +0900 |
| commit | 1fe71ebd0486299de36d4ed551d38043ce8a419b (patch) | |
| tree | e66671f96118a323e0efc0111fef263821f3dfdc /activerecord/CHANGELOG.md | |
| parent | 3e66ba91d511158e22f90ff96b594d61f40eda01 (diff) | |
| download | rails-1fe71ebd0486299de36d4ed551d38043ce8a419b.tar.gz rails-1fe71ebd0486299de36d4ed551d38043ce8a419b.tar.bz2 rails-1fe71ebd0486299de36d4ed551d38043ce8a419b.zip | |
make change_column_comment and change_table_comment invertible
We can revert migrations using `change_column_comment` or
`change_table_comment` at current master.
However, results are not what we expect: comments are remained in new
status.
This change tells previous comment to these methods in a way like
`change_column_default`.
Diffstat (limited to 'activerecord/CHANGELOG.md')
| -rw-r--r-- | activerecord/CHANGELOG.md | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 3b8767787f..7ae6326fc3 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,8 @@ +* `change_column_comment` and `change_table_comment` are invertible only if + `to` and `from` options are specified. + + *Yoshiyuki Kinjo* + * Don't call commit/rollback callbacks despite a record isn't saved. Fixes #29747. |