diff options
author | Roque Pinel <repinel@gmail.com> | 2015-07-19 22:00:36 -0400 |
---|---|---|
committer | Sean Griffin <sean@thoughtbot.com> | 2015-07-20 09:12:01 -0600 |
commit | 12b0b26df7560ab5199ba830586864085441508f (patch) | |
tree | fc2cc53a6795ee099fec878e4c33f7337f05b476 /activerecord/CHANGELOG.md | |
parent | c0ef95a1c6db3095c4b5f80f8044fbbbdfebeff1 (diff) | |
download | rails-12b0b26df7560ab5199ba830586864085441508f.tar.gz rails-12b0b26df7560ab5199ba830586864085441508f.tar.bz2 rails-12b0b26df7560ab5199ba830586864085441508f.zip |
Fix state being carried over from previous transaction
This clears the transaction record state when the transaction finishes
with a `:committed` status.
Considering the following example where `name` is a required attribute.
Before we had `new_record?` returning `true` for a persisted record:
```ruby
author = Author.create! name: 'foo'
author.name = nil
author.save # => false
author.new_record? # => true
```
Diffstat (limited to 'activerecord/CHANGELOG.md')
-rw-r--r-- | activerecord/CHANGELOG.md | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index aa2438fb3f..d9aa703d19 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,17 @@ +* Fix state being carried over from previous transaction. + + Considering the following example where `name` is a required attribute. + Before we had `new_record?` returning `true` for a persisted record: + + author = Author.create! name: 'foo' + author.name = nil + author.save # => false + author.new_record? # => true + + Fixes #20824. + + *Roque Pinel* + * Correctly ignore `mark_for_destruction` when `autosave` isn't set to `true` when validating associations. |