diff options
| author | Stefan Kanev <stefan.kanev@gmail.com> | 2014-08-09 22:19:02 +0300 |
|---|---|---|
| committer | Sean Griffin <sean@thoughtbot.com> | 2015-07-19 15:52:29 -0600 |
| commit | 0ed096ddf5416fefa3afacb72c64632c02826f95 (patch) | |
| tree | cc715ac6cf6b362738eb219068612ed12577f4ba /activerecord/CHANGELOG.md | |
| parent | 0bd247cc7679adb3c2e30b46ecc9afd57ac46c45 (diff) | |
| download | rails-0ed096ddf5416fefa3afacb72c64632c02826f95.tar.gz rails-0ed096ddf5416fefa3afacb72c64632c02826f95.tar.bz2 rails-0ed096ddf5416fefa3afacb72c64632c02826f95.zip | |
Fix counter_cache for polymorphic associations
Also removes a false positive test that depends on the fixed bug:
At this time, counter_cache does not work with polymorphic relationships
(which is a bug). The test was added to make sure that no
StaleObjectError is raised when the car is destroyed. No such error is
currently raised because the lock version is not incremented by
appending a wheel to the car.
Furthermore, `assert_difference` succeeds because `car.wheels.count`
does not check the counter cache, but the collection size. The test will
fail if it is replaced with `car.wheels_count || 0`.
Diffstat (limited to 'activerecord/CHANGELOG.md')
| -rw-r--r-- | activerecord/CHANGELOG.md | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 997abcb48d..3fa24f3837 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,10 @@ +* Fix a bug where counter_cache doesn't always work with polymorphic + relations. + + Fixes #16407. + + *Stefan Kanev & Sean Griffin* + * Ensure that cyclic associations with autosave don't cause duplicate errors to be added to the parent record. |