aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
diff options
context:
space:
mode:
authorHemant Kumar <hkumar@crri.co.in>2011-01-05 17:26:25 +0530
committerJosé Valim <jose.valim@gmail.com>2011-01-05 13:18:10 +0100
commit8de5595e4d101a53f33ae8c48837855d8594f320 (patch)
tree7c64f2232d7a978ada41f40d810d5167eec05cd0 /activemodel
parent5c666779872e6702f4d826686eab09db37cba062 (diff)
downloadrails-8de5595e4d101a53f33ae8c48837855d8594f320.tar.gz
rails-8de5595e4d101a53f33ae8c48837855d8594f320.tar.bz2
rails-8de5595e4d101a53f33ae8c48837855d8594f320.zip
fix difference between behaviour of blank and empty
Signed-off-by: José Valim <jose.valim@gmail.com>
Diffstat (limited to 'activemodel')
-rw-r--r--activemodel/lib/active_model/errors.rb2
-rw-r--r--activemodel/test/cases/errors_test.rb6
2 files changed, 7 insertions, 1 deletions
diff --git a/activemodel/lib/active_model/errors.rb b/activemodel/lib/active_model/errors.rb
index fdca852c7a..0dc10e3c7d 100644
--- a/activemodel/lib/active_model/errors.rb
+++ b/activemodel/lib/active_model/errors.rb
@@ -147,7 +147,7 @@ module ActiveModel
def empty?
all? { |k, v| v && v.empty? }
end
-
+ alias_method :blank?, :empty?
# Returns an xml formatted representation of the Errors hash.
#
# p.errors.add(:name, "can't be blank")
diff --git a/activemodel/test/cases/errors_test.rb b/activemodel/test/cases/errors_test.rb
index 27821c333b..8cb8f7ba44 100644
--- a/activemodel/test/cases/errors_test.rb
+++ b/activemodel/test/cases/errors_test.rb
@@ -25,7 +25,13 @@ class ErrorsTest < ActiveModel::TestCase
def self.lookup_ancestors
[self]
end
+ end
+ test "should return true if no errors" do
+ person = Person.new
+ person.errors[:foo]
+ assert person.errors.empty?
+ assert person.errors.blank?
end
test "method validate! should work" do