aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
diff options
context:
space:
mode:
authoreileencodes <eileencodes@gmail.com>2016-02-23 15:12:57 -0500
committereileencodes <eileencodes@gmail.com>2016-02-23 15:21:46 -0500
commit2c02bc0a47777ad8cf98e1465c08b1a68151803e (patch)
tree33f657c78b31370c283f130fc60d2ff65e28be09 /activemodel
parente9b96f0d666adfd3484641a4a55feb1c774d3378 (diff)
downloadrails-2c02bc0a47777ad8cf98e1465c08b1a68151803e.tar.gz
rails-2c02bc0a47777ad8cf98e1465c08b1a68151803e.tar.bz2
rails-2c02bc0a47777ad8cf98e1465c08b1a68151803e.zip
Revert changes to validations from PR #18612
In order to fix issue #17621 we added a check to validations that determined if a record should be validated. Based on the existing tests and behavior we wanted we determined the best way to do that was by checking if `!record.peristed? || record.changed? || record.marked_for_destruction?` This change didn't make it into a release until now. When #23790 was opened we realized that `valid?` and `invalid?` were broken and did not work on persisted records because of the `!record.persisted?`. While there is still a bug that #17621 brought up, this change was too drastic and should not be a RC blocker. I will work on fixing this so that we don't break `valid?` but also aren't validating parent records through child records if that parent record is validate false. This change removes the code changes to validate and the corresponding tests. It adds tests for two of the bugs found since Rails 5 beta2 release. Fixes #17621
Diffstat (limited to 'activemodel')
-rw-r--r--activemodel/lib/active_model/validator.rb11
1 files changed, 0 insertions, 11 deletions
diff --git a/activemodel/lib/active_model/validator.rb b/activemodel/lib/active_model/validator.rb
index 21339b628e..109bf038b0 100644
--- a/activemodel/lib/active_model/validator.rb
+++ b/activemodel/lib/active_model/validator.rb
@@ -163,17 +163,6 @@ module ActiveModel
# +ArgumentError+ when invalid options are supplied.
def check_validity!
end
-
- def should_validate?(record) # :nodoc:
- !record.persisted? || record.changed? || record.marked_for_destruction?
- end
-
- # Always validate the record if the attribute is a virtual attribute.
- # We have no way of knowing that the record was changed if the attribute
- # does not exist in the database.
- def unknown_attribute?(record, attribute) # :nodoc:
- !record.attributes.include?(attribute.to_s)
- end
end
# +BlockValidator+ is a special +EachValidator+ which receives a block on initialization