aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
diff options
context:
space:
mode:
authorCarlos Antonio da Silva <carlosantoniodasilva@gmail.com>2012-09-07 13:08:30 -0300
committerCarlos Antonio da Silva <carlosantoniodasilva@gmail.com>2012-09-07 13:08:30 -0300
commit0180e090ab6cbe66f7b521a0c03e278a0463accd (patch)
treeedb51cb72afc689f99aa25a6f553fe228b594407 /activemodel
parenta2035307130544e4d6cdbeafad0d0dd4b1beb7a6 (diff)
downloadrails-0180e090ab6cbe66f7b521a0c03e278a0463accd.tar.gz
rails-0180e090ab6cbe66f7b521a0c03e278a0463accd.tar.bz2
rails-0180e090ab6cbe66f7b521a0c03e278a0463accd.zip
Update Active Model xml serialization test to reflect a change in builder
Due to a change in builder, nil values and empty strings now generates closed tags, so instead of this: <pseudonyms nil=\"true\"></pseudonyms> It generates this: <pseudonyms nil=\"true\"/> Document this change in Rails so that people can track it down easily if necessary.
Diffstat (limited to 'activemodel')
-rw-r--r--activemodel/CHANGELOG.md11
-rwxr-xr-xactivemodel/test/cases/serializers/xml_serialization_test.rb2
2 files changed, 12 insertions, 1 deletions
diff --git a/activemodel/CHANGELOG.md b/activemodel/CHANGELOG.md
index 9d0ff5ba99..d7041055a4 100644
--- a/activemodel/CHANGELOG.md
+++ b/activemodel/CHANGELOG.md
@@ -1,5 +1,16 @@
## Rails 4.0.0 (unreleased) ##
+* Due to a change in builder, nil values and empty strings now generates
+ closed tags, so instead of this:
+
+ <pseudonyms nil=\"true\"></pseudonyms>
+
+ It generates this:
+
+ <pseudonyms nil=\"true\"/>
+
+ *Carlos Antonio da Silva*
+
* Changed inclusion and exclusion validators to accept a symbol for `:in` option.
This allows to use dynamic inclusion/exclusion values using methods, besides the current lambda/proc support.
diff --git a/activemodel/test/cases/serializers/xml_serialization_test.rb b/activemodel/test/cases/serializers/xml_serialization_test.rb
index 8c5a3c5efd..e2bb0dda0b 100755
--- a/activemodel/test/cases/serializers/xml_serialization_test.rb
+++ b/activemodel/test/cases/serializers/xml_serialization_test.rb
@@ -133,7 +133,7 @@ class XmlSerializationTest < ActiveModel::TestCase
end
test "should serialize nil" do
- assert_match %r{<pseudonyms nil=\"true\"></pseudonyms>}, @contact.to_xml(:methods => :pseudonyms)
+ assert_match %r{<pseudonyms nil=\"true\"/>}, @contact.to_xml(:methods => :pseudonyms)
end
test "should serialize integer" do