aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel/test
diff options
context:
space:
mode:
authorGenadi Samokovarov <gsamokovarov@gmail.com>2017-11-07 10:28:19 +0200
committerGenadi Samokovarov <gsamokovarov@gmail.com>2017-11-07 10:42:07 +0200
commitbbe437faecca5fd6bdc2327a4bc7a31ba21afe2e (patch)
tree8d68bd91814a715541ec481f6eb1b0bf78b8d8f7 /activemodel/test
parent204b22fa1c739e07d8487ace5710f8f2abe27c0e (diff)
downloadrails-bbe437faecca5fd6bdc2327a4bc7a31ba21afe2e.tar.gz
rails-bbe437faecca5fd6bdc2327a4bc7a31ba21afe2e.tar.bz2
rails-bbe437faecca5fd6bdc2327a4bc7a31ba21afe2e.zip
Use plain assert in assert_changes to avoid MT6 refutes
Seeing the previously issued PRs about it, we can avoid the `nil` comparisons that can happen in `assert_changes` by using plain `assert` calls. This is to avoid a deprecation warning about comparing `nil` values in `assert_equal` for Minitest 5 and a crash in Minitest 6. You can see the preparations done in [`assert_equal`][ae]. You can also see that [`assert`][a] does not care about `nil`s. [ae]: https://github.com/seattlerb/minitest/blob/ca6a71ca901016db09a5ad466b4adea4b52a504a/lib/minitest/assertions.rb#L159-L188 [a]: https://github.com/seattlerb/minitest/blob/ca6a71ca901016db09a5ad466b4adea4b52a504a/lib/minitest/assertions.rb#L131-L142
Diffstat (limited to 'activemodel/test')
0 files changed, 0 insertions, 0 deletions