diff options
author | Sean Griffin <sean@seantheprogrammer.com> | 2016-05-30 15:54:04 -0400 |
---|---|---|
committer | Sean Griffin <sean@seantheprogrammer.com> | 2016-05-30 15:58:03 -0400 |
commit | 02da8aea832485044fde1b94c021a66d37d54dec (patch) | |
tree | 833b858d9e41f757cb36bb2555367ccd7b130f5f /activemodel/lib/active_model/validations/clusivity.rb | |
parent | 518893f82be616a22176a8671e394d4ccb6b6c58 (diff) | |
download | rails-02da8aea832485044fde1b94c021a66d37d54dec.tar.gz rails-02da8aea832485044fde1b94c021a66d37d54dec.tar.bz2 rails-02da8aea832485044fde1b94c021a66d37d54dec.zip |
Exists shouldn't error when used with `includes`
Currently `exists?` does some hackery where it assumes that we can join
onto anything that we passed to `eager_load` or `includes`, which
doesn't work if we are joining onto a polymorphic association.
Actually figuring out if we want to include something would require
knowledge deep within the join dependency module, which is hard to pull
up. The simplest solution is just to pass a flag down that says we're
not actually going to try to eager load any of the data. It's not the
solution I'd like, but that code really needs to be untangled before we
can do much with it.
This is another attempt at 6d5b1fd which should address the concerns
that led to reverting it in 4ecabed.
Diffstat (limited to 'activemodel/lib/active_model/validations/clusivity.rb')
0 files changed, 0 insertions, 0 deletions