diff options
author | Sean Griffin <sean@seantheprogrammer.com> | 2016-03-24 16:06:40 -0600 |
---|---|---|
committer | Sean Griffin <sean@seantheprogrammer.com> | 2016-03-24 16:09:19 -0600 |
commit | c7d3bd48dff0a509f5c21ec8864cb4f774d604e6 (patch) | |
tree | e187eee3bfeb528d3f3719d36d462713267e8f9f /activemodel/lib/active_model/locale/en.yml | |
parent | a12ad8ae542d0d96249be7db6f708ead4d7054aa (diff) | |
download | rails-c7d3bd48dff0a509f5c21ec8864cb4f774d604e6.tar.gz rails-c7d3bd48dff0a509f5c21ec8864cb4f774d604e6.tar.bz2 rails-c7d3bd48dff0a509f5c21ec8864cb4f774d604e6.zip |
Apply scale before precision when coercing floats to decimal
Since precision is always larger than scale, it can actually change
rounding behavior. Given a precision of 5 and a scale of 3, when you
apply the precision of 5 to `1.25047`, the result is `1.2505`, which
when the scale is applied would be `1.251` instead of the expected
`1.250`.
This issue appears to only occur with floats, as scale doesn't apply to
other numeric types, and the bigdecimal constructor actually ignores
precision entirely when working with strings. There's no way we could
handle this for the "unknown object which responds to `to_d`" case, as
we can't assume an interface for applying the scale.
Fixes #24235
Diffstat (limited to 'activemodel/lib/active_model/locale/en.yml')
0 files changed, 0 insertions, 0 deletions