diff options
| author | Sayan Chakraborty <mail.sayanc@gmail.com> | 2017-07-01 19:18:18 +0530 |
|---|---|---|
| committer | Sayan Chakraborty <mail.sayanc@gmail.com> | 2017-12-17 23:56:16 +0530 |
| commit | eb73dfc0677cb5b3a0f559020fe5d7df556056b4 (patch) | |
| tree | f3973a4e3105381205e669228f12ef46476e3b3f /activemodel/CHANGELOG.md | |
| parent | de354cc3573e8b6e81448080a21c313f5bdbab7b (diff) | |
| download | rails-eb73dfc0677cb5b3a0f559020fe5d7df556056b4.tar.gz rails-eb73dfc0677cb5b3a0f559020fe5d7df556056b4.tar.bz2 rails-eb73dfc0677cb5b3a0f559020fe5d7df556056b4.zip | |
Return correct date in ActiveModel for time to date conversions
time.to_date conversion happens considering leap years
so a conversion of "Day.new({'day(1i)'=>'1', 'day(2i)'=>'1', 'day(3i)'=>'1'})" results in saving the date as Mon, 03 Jan 0001
which might seem weird on the user level, hence falling back to parsing on string level resolves this data mismatch
Fixes #28521
Diffstat (limited to 'activemodel/CHANGELOG.md')
| -rw-r--r-- | activemodel/CHANGELOG.md | 17 |
1 files changed, 16 insertions, 1 deletions
diff --git a/activemodel/CHANGELOG.md b/activemodel/CHANGELOG.md index 2dfde11707..909fbe512b 100644 --- a/activemodel/CHANGELOG.md +++ b/activemodel/CHANGELOG.md @@ -1,6 +1,21 @@ ## Rails 5.2.0.beta2 (November 28, 2017) ## -* No changes. +* Return correct date while converting parameters in `value_from_multiparameter_assignment` + for `ActiveModel::Type::Date` + + Before: + + Day.new({"day(1i)"=>"1", "day(2i)"=>"1", "day(3i)"=>"1"}) + => #<Day id: nil, day: "0001-01-03", created_at: nil, updated_at: nil> + + After: + + Day.new({"day(1i)"=>"1", "day(2i)"=>"1", "day(3i)"=>"1"}) + => #<Day id: nil, day: "0001-01-01", created_at: nil, updated_at: nil> + + Fixes #28521 + + *Sayan Chakraborty* ## Rails 5.2.0.beta1 (November 27, 2017) ## |