aboutsummaryrefslogtreecommitdiffstats
path: root/activejob/test
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2017-10-13 12:58:48 +0900
committerGitHub <noreply@github.com>2017-10-13 12:58:48 +0900
commita254454debf42dd4ab052c90e6434d75f9a5a7c8 (patch)
treeb92a041aba08dc1d75d78f718eca88c14a4229f1 /activejob/test
parent62ff514d33d3a3b0930956a4b4866e6b228c278c (diff)
parent34d7b05d277e96d31cab40f7818dcc2e8b107a30 (diff)
downloadrails-a254454debf42dd4ab052c90e6434d75f9a5a7c8.tar.gz
rails-a254454debf42dd4ab052c90e6434d75f9a5a7c8.tar.bz2
rails-a254454debf42dd4ab052c90e6434d75f9a5a7c8.zip
Merge pull request #30750 from k2nr/fix-active-job
Yield with an error instance instead of error class
Diffstat (limited to 'activejob/test')
-rw-r--r--activejob/test/cases/exceptions_test.rb2
-rw-r--r--activejob/test/jobs/retry_job.rb2
2 files changed, 2 insertions, 2 deletions
diff --git a/activejob/test/cases/exceptions_test.rb b/activejob/test/cases/exceptions_test.rb
index 7a3c372143..22fed0a808 100644
--- a/activejob/test/cases/exceptions_test.rb
+++ b/activejob/test/cases/exceptions_test.rb
@@ -61,7 +61,7 @@ class ExceptionsTest < ActiveJob::TestCase
test "custom handling of job that exceeds retry attempts" do
perform_enqueued_jobs do
RetryJob.perform_later "CustomCatchError", 6
- assert_equal "Dealt with a job that failed to retry in a custom way after 6 attempts", JobBuffer.last_value
+ assert_equal "Dealt with a job that failed to retry in a custom way after 6 attempts. Message: CustomCatchError", JobBuffer.last_value
end
end
diff --git a/activejob/test/jobs/retry_job.rb b/activejob/test/jobs/retry_job.rb
index a12d09779b..9aa99d9a21 100644
--- a/activejob/test/jobs/retry_job.rb
+++ b/activejob/test/jobs/retry_job.rb
@@ -17,7 +17,7 @@ class RetryJob < ActiveJob::Base
retry_on ShortWaitTenAttemptsError, wait: 1.second, attempts: 10
retry_on ExponentialWaitTenAttemptsError, wait: :exponentially_longer, attempts: 10
retry_on CustomWaitTenAttemptsError, wait: ->(executions) { executions * 2 }, attempts: 10
- retry_on(CustomCatchError) { |job, exception| JobBuffer.add("Dealt with a job that failed to retry in a custom way after #{job.arguments.second} attempts") }
+ retry_on(CustomCatchError) { |job, exception| JobBuffer.add("Dealt with a job that failed to retry in a custom way after #{job.arguments.second} attempts. Message: #{exception.message}") }
discard_on DiscardableError
def perform(raising, attempts)