diff options
| author | Rafael França <rafaelmfranca@gmail.com> | 2018-01-23 17:07:25 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-01-23 17:07:25 -0500 |
| commit | 4cfd40a5802c7db8d7a6b4f0a9d072f09bfcdbf6 (patch) | |
| tree | fc1c60ce1c407dd649dd60a23c2a76c9afe5f90d /activejob/lib | |
| parent | 0af36c62a5710e023402e37b019ad9982e69de4b (diff) | |
| parent | 66f34a8ea58c8c98d9cc2651d386c9e5a0789d08 (diff) | |
| download | rails-4cfd40a5802c7db8d7a6b4f0a9d072f09bfcdbf6.tar.gz rails-4cfd40a5802c7db8d7a6b4f0a9d072f09bfcdbf6.tar.bz2 rails-4cfd40a5802c7db8d7a6b4f0a9d072f09bfcdbf6.zip | |
Merge pull request #30622 from aidanharan/custom-discarded-job-handling
Allow for custom handling of exceptions that are discarded
Diffstat (limited to 'activejob/lib')
| -rw-r--r-- | activejob/lib/active_job/exceptions.rb | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/activejob/lib/active_job/exceptions.rb b/activejob/lib/active_job/exceptions.rb index 8b4a88ba6a..ae700848d0 100644 --- a/activejob/lib/active_job/exceptions.rb +++ b/activejob/lib/active_job/exceptions.rb @@ -61,18 +61,28 @@ module ActiveJob # Discard the job with no attempts to retry, if the exception is raised. This is useful when the subject of the job, # like an Active Record, is no longer available, and the job is thus no longer relevant. # + # You can also pass a block that'll be invoked. This block is yielded with the job instance as the first and the error instance as the second parameter. + # # ==== Example # # class SearchIndexingJob < ActiveJob::Base # discard_on ActiveJob::DeserializationError + # discard_on(CustomAppException) do |job, exception| + # ExceptionNotifier.caught(exception) + # end # # def perform(record) # # Will raise ActiveJob::DeserializationError if the record can't be deserialized + # # Might raise CustomAppException for something domain specific # end # end def discard_on(exception) rescue_from exception do |error| - logger.error "Discarded #{self.class} due to a #{exception}. The original exception was #{error.cause.inspect}." + if block_given? + yield self, exception + else + logger.error "Discarded #{self.class} due to a #{exception}. The original exception was #{error.cause.inspect}." + end end end end |