aboutsummaryrefslogtreecommitdiffstats
path: root/activejob/bin
diff options
context:
space:
mode:
authorJohn Hawthorn <john@hawthorn.email>2019-04-22 11:39:23 -0700
committerJohn Hawthorn <john@hawthorn.email>2019-04-22 14:53:38 -0700
commit5d9359bbc3e74f3d1433466174409411185ca49e (patch)
treecf30ab42c5b38bda721f6293c83306d9613064f4 /activejob/bin
parentcc834db1d0815744cfa173813c05d928e008e167 (diff)
downloadrails-5d9359bbc3e74f3d1433466174409411185ca49e.tar.gz
rails-5d9359bbc3e74f3d1433466174409411185ca49e.tar.bz2
rails-5d9359bbc3e74f3d1433466174409411185ca49e.zip
Use ActiveJob 5.2 retry logic for old jobs
Rails 6 introduces retries per-exception, instead of a global count of retries. Because ActiveJob 5.2 doesn't serialize the execution count per-exception, when ActiveJob 6.0 picks up an "old" job it can't know the exception count in the new format. This can also be an issue if AJ 6.0 serializes a new job with exception_executions which is later picked up by AJ 5.2, which would clear exception_executions (since it has no knowledge of it). Previously we handled this by resetting exception_executions, if it wasn't defined on a job, which could result in the worst case retrying the job 2x the times we should. This commit changes how we handle loading a legacy job: instead of resetting exception_executions, we instead will always use the global executions count. This way, jobs which only have one retry_on (and didn't have a behaviour change in AJ 6) are backwards-and-forwards-compatible with counts respected exactly. Jobs with multiple retry_on will revert to the AJ5.2 behaviour if they were ever run under AJ5.2.
Diffstat (limited to 'activejob/bin')
0 files changed, 0 insertions, 0 deletions