diff options
| author | Johannes Opper <johannes.opper@gmail.com> | 2015-07-07 21:52:28 +0200 |
|---|---|---|
| committer | Johannes Opper <johannes.opper@gmail.com> | 2015-08-04 00:38:18 +0200 |
| commit | 3860e6b2bf486d8b27d433daab358dbc68ae3448 (patch) | |
| tree | 136f0b6e7cfeac3ef48ea1c41c37332083dba8d2 /activejob/CHANGELOG.md | |
| parent | e598967548114da4f8d85070584460108a7305ff (diff) | |
| download | rails-3860e6b2bf486d8b27d433daab358dbc68ae3448.tar.gz rails-3860e6b2bf486d8b27d433daab358dbc68ae3448.tar.bz2 rails-3860e6b2bf486d8b27d433daab358dbc68ae3448.zip | |
Fixes #20799
When `#perform_later` is called the locale isn't stored on the
queue, which results in a locale reset when the job is performed.
An example of the problem:
I18n.locale = 'de'
HelloJob.perform_now # german message, correct
but
I18n.locale = 'de'
HelloJob.perform_later # english message, incorrect
This PR attaches the current I18n.locale to every job during the
serialization process. It is then restored during deserialization
and used to perform the job with the correct locale.
It falls back to the default locale if no serialized locale is
found in order to provide backward compatibility with previously
stored jobs. It is not necessary to clear the queue for the update.
Diffstat (limited to 'activejob/CHANGELOG.md')
| -rw-r--r-- | activejob/CHANGELOG.md | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/activejob/CHANGELOG.md b/activejob/CHANGELOG.md index c523723fc4..1bd97eed38 100644 --- a/activejob/CHANGELOG.md +++ b/activejob/CHANGELOG.md @@ -1,3 +1,10 @@ +* Include I18n.locale into job serialization/deserialization and use it around + `perform`. + + Fixes #20799. + + *Johannes Opper* + * Allow `DelayedJob`, `Sidekiq`, `qu`, and `que` to report the job id back to `ActiveJob::Base` as `provider_job_id`. |