aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
diff options
context:
space:
mode:
authorPablo Herrero <pablodherrero@gmail.com>2014-11-01 20:16:03 -0300
committerPablo Herrero <pablodherrero@gmail.com>2014-11-01 20:23:29 -0300
commit861b70e92f4a1fc0e465ffcf2ee62680519c8f6f (patch)
treecc5ce3c824b091cc88fb2c9c1f8557905108f265 /actionview
parentdaab7e59a6196fa2bbab17dc4a88b095a211fc96 (diff)
downloadrails-861b70e92f4a1fc0e465ffcf2ee62680519c8f6f.tar.gz
rails-861b70e92f4a1fc0e465ffcf2ee62680519c8f6f.tar.bz2
rails-861b70e92f4a1fc0e465ffcf2ee62680519c8f6f.zip
Call gsub with a Regexp instead of a String for better performance
Diffstat (limited to 'actionview')
-rw-r--r--actionview/lib/action_view/helpers/tag_helper.rb2
-rw-r--r--actionview/lib/action_view/template/handlers/raw.rb2
2 files changed, 2 insertions, 2 deletions
diff --git a/actionview/lib/action_view/helpers/tag_helper.rb b/actionview/lib/action_view/helpers/tag_helper.rb
index 385d57a7a5..b2038576a2 100644
--- a/actionview/lib/action_view/helpers/tag_helper.rb
+++ b/actionview/lib/action_view/helpers/tag_helper.rb
@@ -123,7 +123,7 @@ module ActionView
# cdata_section("hello]]>world")
# # => <![CDATA[hello]]]]><![CDATA[>world]]>
def cdata_section(content)
- splitted = content.to_s.gsub(']]>', ']]]]><![CDATA[>')
+ splitted = content.to_s.gsub(/\]\]\>/, ']]]]><![CDATA[>')
"<![CDATA[#{splitted}]]>".html_safe
end
diff --git a/actionview/lib/action_view/template/handlers/raw.rb b/actionview/lib/action_view/template/handlers/raw.rb
index 0c0d1fffcb..397c86014a 100644
--- a/actionview/lib/action_view/template/handlers/raw.rb
+++ b/actionview/lib/action_view/template/handlers/raw.rb
@@ -2,7 +2,7 @@ module ActionView
module Template::Handlers
class Raw
def call(template)
- escaped = template.source.gsub(':', '\:')
+ escaped = template.source.gsub(/:/, '\:')
'%q:' + escaped + ':;'
end