diff options
| author | Clayton Smith <clayton.smith@shopify.com> | 2015-07-23 16:36:13 -0400 |
|---|---|---|
| committer | Clayton Smith <clayton.smith@shopify.com> | 2015-07-23 16:56:21 -0400 |
| commit | 6a387824775430fef2a0075ddd7b9d31e8c5cb48 (patch) | |
| tree | df0370e6c4649817bbc33d15f5a0425d5a1f64ad /actionview | |
| parent | cdc32defcfc2ce5312c4b02e09f6cef2172843c6 (diff) | |
| download | rails-6a387824775430fef2a0075ddd7b9d31e8c5cb48.tar.gz rails-6a387824775430fef2a0075ddd7b9d31e8c5cb48.tar.bz2 rails-6a387824775430fef2a0075ddd7b9d31e8c5cb48.zip | |
Encode the email address as prescribed in RFC 6068 section 2.
Diffstat (limited to 'actionview')
| -rw-r--r-- | actionview/lib/action_view/helpers/url_helper.rb | 3 | ||||
| -rw-r--r-- | actionview/test/template/url_helper_test.rb | 7 |
2 files changed, 9 insertions, 1 deletions
diff --git a/actionview/lib/action_view/helpers/url_helper.rb b/actionview/lib/action_view/helpers/url_helper.rb index afb1265ad9..7d92651183 100644 --- a/actionview/lib/action_view/helpers/url_helper.rb +++ b/actionview/lib/action_view/helpers/url_helper.rb @@ -468,7 +468,8 @@ module ActionView }.compact extras = extras.empty? ? '' : '?' + extras.join('&') - html_options["href"] = "mailto:#{email_address}#{extras}" + encoded_email_address = ERB::Util.url_encode(email_address).gsub("%40", "@") + html_options["href"] = "mailto:#{encoded_email_address}#{extras}" content_tag(:a, name || email_address, html_options, &block) end diff --git a/actionview/test/template/url_helper_test.rb b/actionview/test/template/url_helper_test.rb index 0e35c67516..416d30938a 100644 --- a/actionview/test/template/url_helper_test.rb +++ b/actionview/test/template/url_helper_test.rb @@ -500,6 +500,13 @@ class UrlHelperTest < ActiveSupport::TestCase mail_to("david@loudthinking.com", "David Heinemeier Hansson", class: "admin") end + def test_mail_to_with_special_characters + assert_dom_equal( + %{<a href="mailto:%23%21%24%25%26%27%2A%2B-%2F%3D%3F%5E_%60%7B%7D%7C%7E@example.org">#!$%&'*+-/=?^_`{}|~@example.org</a>}, + mail_to("#!$%&'*+-/=?^_`{}|~@example.org") + ) + end + def test_mail_with_options assert_dom_equal( %{<a href="mailto:me@example.com?cc=ccaddress%40example.com&bcc=bccaddress%40example.com&body=This%20is%20the%20body%20of%20the%20message.&subject=This%20is%20an%20example%20email&reply-to=foo%40bar.com">My email</a>}, |