diff options
author | Yuki Nishijima <yk.nishijima@gmail.com> | 2019-01-24 15:49:05 -0500 |
---|---|---|
committer | Yuki Nishijima <yk.nishijima@gmail.com> | 2019-01-24 15:49:05 -0500 |
commit | 6922ba6cb61e4c833cca0b302bc1cf0f93f7ce93 (patch) | |
tree | 9358dc14fb7f72bcd021bbdbe43e784939d92c2a /actionview | |
parent | c91c71fa154951bde42839b26c9d0f9dd3005fd9 (diff) | |
download | rails-6922ba6cb61e4c833cca0b302bc1cf0f93f7ce93.tar.gz rails-6922ba6cb61e4c833cca0b302bc1cf0f93f7ce93.tar.bz2 rails-6922ba6cb61e4c833cca0b302bc1cf0f93f7ce93.zip |
Prefer strings over regex expressions
In this case statement, there are two patterns that start with the same
line:
when %r{/not_found}
...
when %r{/not_found_original_exception}
...
Because the string "/not_found_original_exception" does match the first
one, it is never routed to what it is supposed to be routed, causing one
of the tests for DebugExceptions to happen to be passing.
After changing the regex expressions back to strings, I noticed that the
test setup is not complete (the template object needs to be a proper
template object). Once I fixed it all the tests started padding.
Diffstat (limited to 'actionview')
0 files changed, 0 insertions, 0 deletions