aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test
diff options
context:
space:
mode:
authorRafael Mendonça França <rafaelmfranca@gmail.com>2014-07-15 13:59:10 -0300
committerRafael Mendonça França <rafaelmfranca@gmail.com>2014-07-15 13:59:10 -0300
commitf5426315d91a0445506a8c56b6f02edde7337507 (patch)
tree0e5a653a7925e038b06ee684f25b0db5d6e2e12e /actionview/test
parentc0026d5ba18ea5b17d6d5b62d8abdbe3a3935901 (diff)
downloadrails-f5426315d91a0445506a8c56b6f02edde7337507.tar.gz
rails-f5426315d91a0445506a8c56b6f02edde7337507.tar.bz2
rails-f5426315d91a0445506a8c56b6f02edde7337507.zip
All these tests are passing now
Diffstat (limited to 'actionview/test')
-rw-r--r--actionview/test/template/date_helper_test.rb4
-rw-r--r--actionview/test/template/form_helper_test.rb2
-rw-r--r--actionview/test/template/text_helper_test.rb1
3 files changed, 0 insertions, 7 deletions
diff --git a/actionview/test/template/date_helper_test.rb b/actionview/test/template/date_helper_test.rb
index 327ed43188..0cdb130710 100644
--- a/actionview/test/template/date_helper_test.rb
+++ b/actionview/test/template/date_helper_test.rb
@@ -2131,8 +2131,6 @@ class DateHelperTest < ActionView::TestCase
end
def test_time_select_with_html_options_within_fields_for
- skip "Pending. Output error: 'unknown encoding ASCII-8BIT' makes Loofah return an empty string. Related: https://github.com/sparklemotion/nokogiri/issues/553"
-
@post = Post.new
@post.written_on = Time.local(2004, 6, 15, 15, 16, 35)
@@ -2370,7 +2368,6 @@ class DateHelperTest < ActionView::TestCase
end
def test_datetime_select_with_html_options_within_fields_for
- skip "Pending. Output error: 'unknown encoding ASCII-8BIT' makes Loofah return an empty string. Related: https://github.com/sparklemotion/nokogiri/issues/553"
@post = Post.new
@post.updated_at = Time.local(2004, 6, 15, 16, 35)
@@ -2622,7 +2619,6 @@ class DateHelperTest < ActionView::TestCase
end
def test_datetime_select_within_fields_for_with_options_index
- skip "Pending. Output error: 'unknown encoding ASCII-8BIT' makes Loofah return an empty string. Related: https://github.com/sparklemotion/nokogiri/issues/553"
@post = Post.new
@post.updated_at = Time.local(2004, 6, 15, 16, 35)
id = 456
diff --git a/actionview/test/template/form_helper_test.rb b/actionview/test/template/form_helper_test.rb
index 5cd094559f..3e39dadcf1 100644
--- a/actionview/test/template/form_helper_test.rb
+++ b/actionview/test/template/form_helper_test.rb
@@ -2921,8 +2921,6 @@ class FormHelperTest < ActionView::TestCase
end
def test_fields_for_with_labelled_builder
- skip "Pending. I think that there's an output error: 'unknown encoding ASCII-8BIT' in here, which makes Loofah return an empty string. Related: https://github.com/sparklemotion/nokogiri/issues/553"
-
output_buffer = fields_for(:post, @post, builder: LabelledFormBuilder) do |f|
concat f.text_field(:title)
concat f.text_area(:body)
diff --git a/actionview/test/template/text_helper_test.rb b/actionview/test/template/text_helper_test.rb
index f7809e162c..667f9002da 100644
--- a/actionview/test/template/text_helper_test.rb
+++ b/actionview/test/template/text_helper_test.rb
@@ -190,7 +190,6 @@ class TextHelperTest < ActionView::TestCase
end
def test_highlight_pending
- skip "Pending. Nokogiri parses a blank string, sees no elements and then returns ''"
assert_equal ' ', highlight(' ', 'blank text is returned verbatim')
end