diff options
| author | Vipul A M <vipulnsward@gmail.com> | 2016-05-09 02:36:58 +0530 |
|---|---|---|
| committer | Vipul A M <vipulnsward@gmail.com> | 2016-05-21 15:43:35 +0800 |
| commit | 9bfd968bed1a76888ec82e0f7b524a989d0e1108 (patch) | |
| tree | 67b396ef0b92385bd5996fb0617abab989f166e9 /actionview/test | |
| parent | 694cbbf801e46d7ec533ece4637412838f02723e (diff) | |
| download | rails-9bfd968bed1a76888ec82e0f7b524a989d0e1108.tar.gz rails-9bfd968bed1a76888ec82e0f7b524a989d0e1108.tar.bz2 rails-9bfd968bed1a76888ec82e0f7b524a989d0e1108.zip | |
Confirm with the specification when generating emtpy option for select with `include_blank: true` option.
We now generate option with empty label, example:
`<select id="places" name="places"><option value="" label=" "></option></select>`
for include_blank: true. This is only done, if content is missing on the option, and we providing the value from this option.
Fixes #24816
Diffstat (limited to 'actionview/test')
| -rw-r--r-- | actionview/test/template/form_tag_helper_test.rb | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/actionview/test/template/form_tag_helper_test.rb b/actionview/test/template/form_tag_helper_test.rb index 7b93c8dc29..5b0b708618 100644 --- a/actionview/test/template/form_tag_helper_test.rb +++ b/actionview/test/template/form_tag_helper_test.rb @@ -239,8 +239,8 @@ class FormTagHelperTest < ActionView::TestCase end def test_select_tag_with_include_blank - actual = select_tag "places", raw("<option>Home</option><option>Work</option><option>Pub</option>"), :include_blank => true - expected = %(<select id="places" name="places"><option value=""></option><option>Home</option><option>Work</option><option>Pub</option></select>) + actual = select_tag "places", raw("<option>Home</option><option>Work</option><option>Pub</option>"), include_blank: true + expected = %(<select id="places" name="places"><option value="" label=" "></option><option>Home</option><option>Work</option><option>Pub</option></select>) assert_dom_equal expected, actual end @@ -269,14 +269,14 @@ class FormTagHelperTest < ActionView::TestCase end def test_select_tag_with_prompt_and_include_blank - actual = select_tag "places", raw("<option>Home</option><option>Work</option><option>Pub</option>"), :prompt => "string", :include_blank => true - expected = %(<select name="places" id="places"><option value="">string</option><option value=""></option><option>Home</option><option>Work</option><option>Pub</option></select>) + actual = select_tag "places", raw("<option>Home</option><option>Work</option><option>Pub</option>"), prompt: "string", include_blank: true + expected = %(<select name="places" id="places"><option value="">string</option><option value="" label=" "></option><option>Home</option><option>Work</option><option>Pub</option></select>) assert_dom_equal expected, actual end def test_select_tag_with_nil_option_tags_and_include_blank actual = select_tag "places", nil, :include_blank => true - expected = %(<select id="places" name="places"><option value=""></option></select>) + expected = %(<select id="places" name="places"><option value="" label=" "></option></select>) assert_dom_equal expected, actual end |