Silenced deprecation warnings in the tests. Documentation uses present tense. Changed deprecation message to not use you. Also returning from rescue block in catch_invalid_selector to abort reraising the exception.

1 files changed, 6 insertions, 2 deletions

diff --git a/actionview/test/template/assert_select_test.rb b/actionview/test/template/assert_select_test.rb
index af1ddb5c12..e53b9635e5 100644
--- a/actionview/test/template/assert_select_test.rb
+++ b/actionview/test/template/assert_select_test.rb
@@ -269,12 +269,16 @@ class AssertSelectTest < ActionController::TestCase
   # testing invalid selectors
   def test_assert_select_with_invalid_selector
     render_html '<a href="http://example.com">hello</a>'
-    assert_nil assert_select("[href=http://example.com]")
+    ActiveSupport::Deprecation.silence do
+      assert_nil assert_select("[href=http://example.com]")
+    end
   end
 
   def test_css_select_with_invalid_selector
     render_html '<a href="http://example.com">hello</a>'
-    assert_nil css_select("[href=http://example.com]")
+    ActiveSupport::Deprecation.silence do
+      assert_nil css_select("[href=http://example.com]")
+    end
   end
 
   def test_feed_item_encoded