diff options
| author | Georgi Georgiev <gtqnchev@gmail.com> | 2017-12-02 20:45:10 +0200 |
|---|---|---|
| committer | Georgi Georgiev <gtqnchev@gmail.com> | 2018-07-16 09:44:22 +0300 |
| commit | 113d8a2ba39da13840845bac3aa4f274a1dae19b (patch) | |
| tree | 02889c40f541e06bb2e2b48786c40109e8ede698 /actionview/test | |
| parent | cd84d8716497010464cc2fb14f6ac9fe12b7efb7 (diff) | |
| download | rails-113d8a2ba39da13840845bac3aa4f274a1dae19b.tar.gz rails-113d8a2ba39da13840845bac3aa4f274a1dae19b.tar.bz2 rails-113d8a2ba39da13840845bac3aa4f274a1dae19b.zip | |
Fix issue with `button_to`'s `to_form_params`
`button_to` was throwing exception when invoked with `params` hash that
contains symbol and string keys. The reason for the exception was that
`to_form_params` was comparing the given symbol and string keys.
The issue is fixed by turning all keys to strings inside
`to_form_params` before comparing them.
Diffstat (limited to 'actionview/test')
| -rw-r--r-- | actionview/test/template/url_helper_test.rb | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/actionview/test/template/url_helper_test.rb b/actionview/test/template/url_helper_test.rb index 08cb5dfea7..9d91dbb72b 100644 --- a/actionview/test/template/url_helper_test.rb +++ b/actionview/test/template/url_helper_test.rb @@ -77,11 +77,18 @@ class UrlHelperTest < ActiveSupport::TestCase def test_to_form_params_with_hash assert_equal( - [{ name: :name, value: "David" }, { name: :nationality, value: "Danish" }], + [{ name: "name", value: "David" }, { name: "nationality", value: "Danish" }], to_form_params(name: "David", nationality: "Danish") ) end + def test_to_form_params_with_hash_having_symbol_and_string_keys + assert_equal( + [{ name: "name", value: "David" }, { name: "nationality", value: "Danish" }], + to_form_params("name" => "David", :nationality => "Danish") + ) + end + def test_to_form_params_with_nested_hash assert_equal( [{ name: "country[name]", value: "Denmark" }], |