diff options
author | Michael Koziarski <michael@koziarski.com> | 2013-11-01 11:50:05 +1300 |
---|---|---|
committer | Aaron Patterson <aaron.patterson@gmail.com> | 2013-12-02 16:42:16 -0800 |
commit | 0c7ac34aed1845044cd1911e5a775366d7ca41c1 (patch) | |
tree | 462daeee4fbdd1ab60134d5343d05ea44bb0b854 /actionview/test | |
parent | bea9c9b4c0f9bb7356ea2058118fe40495432010 (diff) | |
download | rails-0c7ac34aed1845044cd1911e5a775366d7ca41c1.tar.gz rails-0c7ac34aed1845044cd1911e5a775366d7ca41c1.tar.bz2 rails-0c7ac34aed1845044cd1911e5a775366d7ca41c1.zip |
Stop using i18n's built in HTML error handling.
i18n doesn't depend on active support which means it can't use our html_safe
code to do its escaping when generating the spans. Rather than try to sanitize
the output from i18n, just revert to our old behaviour of rescuing the error
and constructing the tag ourselves.
Fixes: CVE-2013-4491
Diffstat (limited to 'actionview/test')
-rw-r--r-- | actionview/test/template/translation_helper_test.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/actionview/test/template/translation_helper_test.rb b/actionview/test/template/translation_helper_test.rb index d496dbb35e..0dfe47f5f4 100644 --- a/actionview/test/template/translation_helper_test.rb +++ b/actionview/test/template/translation_helper_test.rb @@ -31,7 +31,7 @@ class TranslationHelperTest < ActiveSupport::TestCase end def test_delegates_to_i18n_setting_the_rescue_format_option_to_html - I18n.expects(:translate).with(:foo, :locale => 'en', :rescue_format => :html).returns("") + I18n.expects(:translate).with(:foo, :locale => 'en', :raise=>true).returns("") translate :foo, :locale => 'en' end |