diff options
author | claudiob <claudiob@gmail.com> | 2014-12-15 08:26:41 -0800 |
---|---|---|
committer | claudiob <claudiob@gmail.com> | 2014-12-15 16:36:50 -0800 |
commit | 8dfa585db2539d8e5d933ac57e19c07fb6daa953 (patch) | |
tree | ff2771493be4495cd460e65a77b79b5442f3f449 /actionview/test/template/url_helper_test.rb | |
parent | 1b9dca54fd5c65ed8b4aa96e2b6826cefb2c3e62 (diff) | |
download | rails-8dfa585db2539d8e5d933ac57e19c07fb6daa953.tar.gz rails-8dfa585db2539d8e5d933ac57e19c07fb6daa953.tar.bz2 rails-8dfa585db2539d8e5d933ac57e19c07fb6daa953.zip |
Remove misleading test: around_action return false
When an `around_action` does not `yield`, then the corresponding action is
*never* executed and the `after_` actions are *never* invoked.
The value returned by the `around_action` does not have any impact on this:
an `around_action` can "return" `true`, `false`, or `"pizza"`, but as long
as `yield` is not invoked, the corresponding action and after callbacks are
not executed.
The test suite for `ActionController::Callbacks` currently includes separate
tests to distinguish the cases in which a non-yielding `around_actions` returns
`true` or `false`.
In my opinion, having such tests is misleading, giving the impression that the
returned value might have some sort of impact, while it does not. At least
that's the impression I got when I read those tests.
For completeness, the tests were introduced 7 years ago by @NZKoz in e80fabb.
Diffstat (limited to 'actionview/test/template/url_helper_test.rb')
0 files changed, 0 insertions, 0 deletions