diff options
| author | Eileen Uchitelle <eileencodes@gmail.com> | 2018-10-09 14:08:25 -0400 |
|---|---|---|
| committer | Eileen Uchitelle <eileencodes@gmail.com> | 2018-10-10 08:07:12 -0400 |
| commit | e8c1be4ae7797f3ede588d2cf04a0155b4d6ce4a (patch) | |
| tree | 99a96136ddf8581c53da3ce08f3b88660eaa92f8 /actionview/test/template/log_subscriber_test.rb | |
| parent | 168a9728dd00069efe04fec4b59d29e3752fbfb3 (diff) | |
| download | rails-e8c1be4ae7797f3ede588d2cf04a0155b4d6ce4a.tar.gz rails-e8c1be4ae7797f3ede588d2cf04a0155b4d6ce4a.tar.bz2 rails-e8c1be4ae7797f3ede588d2cf04a0155b4d6ce4a.zip | |
Add allocations to template renderer subscription
This PR adds the allocations to the instrumentation for template and
partial rendering.
Before:
```
Rendering posts/new.html.erb within layouts/application
Rendered posts/_form.html.erb (9.7ms)
Rendered posts/new.html.erb within layouts/application (10.9ms)
Completed 200 OK in 902ms (Views: 890.8ms | ActiveRecord: 0.8ms)
```
After:
```
Rendering posts/new.html.erb within layouts/application
Rendered posts/_form.html.erb (Duration: 7.1ms | Allocations: 6004)
Rendered posts/new.html.erb within layouts/application (Duration: 8.3ms | Allocations: 6654)
Completed 200 OK in 858ms (Views: 848.4ms | ActiveRecord: 0.4ms | Allocations: 1539564)
```
Diffstat (limited to 'actionview/test/template/log_subscriber_test.rb')
| -rw-r--r-- | actionview/test/template/log_subscriber_test.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/actionview/test/template/log_subscriber_test.rb b/actionview/test/template/log_subscriber_test.rb index 7f4fd25573..9fcf80bb24 100644 --- a/actionview/test/template/log_subscriber_test.rb +++ b/actionview/test/template/log_subscriber_test.rb @@ -129,14 +129,14 @@ class AVLogSubscriberTest < ActiveSupport::TestCase wait *, cached_inner, uncached_outer = @logger.logged(:info) assert_match(/Rendered test\/_cached_customer\.erb (.*) \[cache miss\]/, cached_inner) - assert_match(/Rendered test\/_nested_cached_customer\.erb \(.*?ms\)$/, uncached_outer) + assert_match(/Rendered test\/_nested_cached_customer\.erb \(Duration: .*?ms \| Allocations: .*?\)$/, uncached_outer) # Second render hits the cache for the _cached_customer partial. Outer template's log shouldn't be affected. @view.render(partial: "test/nested_cached_customer", locals: { cached_customer: Customer.new("Stan") }) wait *, cached_inner, uncached_outer = @logger.logged(:info) assert_match(/Rendered test\/_cached_customer\.erb (.*) \[cache hit\]/, cached_inner) - assert_match(/Rendered test\/_nested_cached_customer\.erb \(.*?ms\)$/, uncached_outer) + assert_match(/Rendered test\/_nested_cached_customer\.erb \(Duration: .*?ms \| Allocations: .*?\)$/, uncached_outer) end end |