diff options
author | Edouard CHIN <edouard.chin@shopify.com> | 2019-02-01 16:00:33 -0500 |
---|---|---|
committer | Edouard CHIN <edouard.chin@shopify.com> | 2019-02-04 14:25:17 +0100 |
commit | 5c668309122e708f304aad959b6328bcaf586e31 (patch) | |
tree | 3d1c11e6b41ad0881c8fcf1ede0bba1ec5924346 /actionview/test/template/controller_helper_test.rb | |
parent | caf8dbc1591c64ae4fd9253a714903710f46f7ce (diff) | |
download | rails-5c668309122e708f304aad959b6328bcaf586e31.tar.gz rails-5c668309122e708f304aad959b6328bcaf586e31.tar.bz2 rails-5c668309122e708f304aad959b6328bcaf586e31.zip |
Cookie doesn't expire anymore unless a flag is set:
- There is a regression in 6.0 introduced by #32937 where cookie
doesn't expire anymore unless the new `use_cookies_with_metadata`
configuration is set to `true`.
This causes issue for app migration from 5.2 to 6.0 because the
`use_cookies_with_metadata` flag can't be set to true until all
servers are running on 6.0.
Here is a small reproduction script that you can run in the console
```ruby
ActionDispatch::Cookies
request = ActionDispatch::Request.empty
request.env["action_dispatch.key_generator"] = ActiveSupport::KeyGenerator.new('1234567890')
request.env["action_dispatch.signed_cookie_salt"] = 'signed cookie'
request.env["action_dispatch.cookies_rotations"] = ActiveSupport::Messages::RotationConfiguration.new
request.env["action_dispatch.use_authenticated_cookie_encryption"] = true
signed_cookie = request.cookie_jar.signed
signed_cookie[:foobar] = { value: '123', expires: 1.day.ago }
p signed_cookie[:foobar]
```
Diffstat (limited to 'actionview/test/template/controller_helper_test.rb')
0 files changed, 0 insertions, 0 deletions