diff options
author | eileencodes <eileencodes@gmail.com> | 2019-06-26 14:25:11 -0400 |
---|---|---|
committer | eileencodes <eileencodes@gmail.com> | 2019-06-27 09:54:25 -0400 |
commit | df6b0de7d9522c46c140c556ee61e09df14ef97a (patch) | |
tree | b343408225debc541b0ef56f3c24312e5d7f4935 /actionview/test/actionpack | |
parent | b65f88652f835093030bf65b9e31e727ba58a6de (diff) | |
download | rails-df6b0de7d9522c46c140c556ee61e09df14ef97a.tar.gz rails-df6b0de7d9522c46c140c556ee61e09df14ef97a.tar.bz2 rails-df6b0de7d9522c46c140c556ee61e09df14ef97a.zip |
Load initial database.yml once, and warn if we can't create tasks
For multiple databases we attempt to generate the tasks by reading the
database.yml before the Rails application is booted. This means that we
need to strip out ERB since it could be reading Rails configs.
In some cases like https://github.com/rails/rails/issues/36540 the ERB
is too complex and we can't overwrite with the DummyCompilier we used in
https://github.com/rails/rails/pull/35497. For the complex causes we
simply issue a warning that says we couldn't infer the database tasks
from the database.yml.
While working on this I decided to update the code to only load the
database.yml once initially so that we avoid having to issue the same
warning multiple times. Note that this had no performance impact in my
testing and is merely for not having to save the error off somewhere.
Also this feels cleaner.
Note that this will not break running tasks that exist, it will just
mean that tasks for multi-db like `db:create:other_db` will not be
generated. If the database.yml is actually unreadable it will blow up
during normal rake task calls.
Fixes #36540
Diffstat (limited to 'actionview/test/actionpack')
0 files changed, 0 insertions, 0 deletions