diff options
author | Carlos Antonio da Silva <carlosantoniodasilva@gmail.com> | 2013-12-19 09:03:39 -0200 |
---|---|---|
committer | Carlos Antonio da Silva <carlosantoniodasilva@gmail.com> | 2013-12-19 09:20:51 -0200 |
commit | c5b76b5362e4ba28ff3a5649156c50dff9a86de7 (patch) | |
tree | 2612d781e96ce592ae609146f303ffda9eb5f104 /actionview/test/actionpack/controller | |
parent | d799b9c1cf888a528d062cd44903cf2e0ce34a2c (diff) | |
download | rails-c5b76b5362e4ba28ff3a5649156c50dff9a86de7.tar.gz rails-c5b76b5362e4ba28ff3a5649156c50dff9a86de7.tar.bz2 rails-c5b76b5362e4ba28ff3a5649156c50dff9a86de7.zip |
Prefer assert_raise instead of flunk + rescue to test for exceptions
Change most tests to make use of assert_raise returning the raised
exception rather than relying on a combination of flunk + rescue to
check for exception types/messages.
Diffstat (limited to 'actionview/test/actionpack/controller')
-rw-r--r-- | actionview/test/actionpack/controller/render_test.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/actionview/test/actionpack/controller/render_test.rb b/actionview/test/actionpack/controller/render_test.rb index 7e28ceb9d8..7e594d5030 100644 --- a/actionview/test/actionpack/controller/render_test.rb +++ b/actionview/test/actionpack/controller/render_test.rb @@ -693,9 +693,9 @@ class RenderTest < ActionController::TestCase end def test_line_offset - get :render_line_offset - flunk "the action should have raised an exception" - rescue StandardError => exc + exc = assert_raises ActionView::Template::Error do + get :render_line_offset + end line = exc.backtrace.first assert(line =~ %r{:(\d+):}) assert_equal "1", $1, |