diff options
| author | Sean Griffin <sean@seantheprogrammer.com> | 2014-11-01 18:48:23 -0600 |
|---|---|---|
| committer | Sean Griffin <sean@seantheprogrammer.com> | 2014-11-01 18:48:23 -0600 |
| commit | 8b611b705b668d98ad2b7cf166f7e99cffca6ba3 (patch) | |
| tree | ed05724bb101dfebb48d138ee58f77777641173c /actionview/lib | |
| parent | 50e7c013c04544091f0081e495cacdd987f4d8e1 (diff) | |
| parent | 861b70e92f4a1fc0e465ffcf2ee62680519c8f6f (diff) | |
| download | rails-8b611b705b668d98ad2b7cf166f7e99cffca6ba3.tar.gz rails-8b611b705b668d98ad2b7cf166f7e99cffca6ba3.tar.bz2 rails-8b611b705b668d98ad2b7cf166f7e99cffca6ba3.zip | |
Merge pull request #17483 from pabloh/optimize_gsub_calls
Call gsub with a Regexp instead of a String for better performance
Diffstat (limited to 'actionview/lib')
| -rw-r--r-- | actionview/lib/action_view/helpers/tag_helper.rb | 2 | ||||
| -rw-r--r-- | actionview/lib/action_view/template/handlers/raw.rb | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/actionview/lib/action_view/helpers/tag_helper.rb b/actionview/lib/action_view/helpers/tag_helper.rb index 385d57a7a5..b2038576a2 100644 --- a/actionview/lib/action_view/helpers/tag_helper.rb +++ b/actionview/lib/action_view/helpers/tag_helper.rb @@ -123,7 +123,7 @@ module ActionView # cdata_section("hello]]>world") # # => <![CDATA[hello]]]]><![CDATA[>world]]> def cdata_section(content) - splitted = content.to_s.gsub(']]>', ']]]]><![CDATA[>') + splitted = content.to_s.gsub(/\]\]\>/, ']]]]><![CDATA[>') "<![CDATA[#{splitted}]]>".html_safe end diff --git a/actionview/lib/action_view/template/handlers/raw.rb b/actionview/lib/action_view/template/handlers/raw.rb index 0c0d1fffcb..397c86014a 100644 --- a/actionview/lib/action_view/template/handlers/raw.rb +++ b/actionview/lib/action_view/template/handlers/raw.rb @@ -2,7 +2,7 @@ module ActionView module Template::Handlers class Raw def call(template) - escaped = template.source.gsub(':', '\:') + escaped = template.source.gsub(/:/, '\:') '%q:' + escaped + ':;' end |