aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib/action_view/helpers/number_helper.rb
diff options
context:
space:
mode:
authorJon Leighton <j@jonathanleighton.com>2013-11-20 21:51:35 +0000
committerJon Leighton <j@jonathanleighton.com>2013-11-20 22:23:16 +0000
commit64b9e93bb571160315987862583a83222e506734 (patch)
tree9e95adb6f1fff0b710719f2a830296d26e32535d /actionview/lib/action_view/helpers/number_helper.rb
parentda800614cac8b5935d0fd352af4a99d73cd13de8 (diff)
downloadrails-64b9e93bb571160315987862583a83222e506734.tar.gz
rails-64b9e93bb571160315987862583a83222e506734.tar.bz2
rails-64b9e93bb571160315987862583a83222e506734.zip
Fix ActiveRecord::Relation#unscope
I'm pretty confused about the addition of this method. The documentation says that it was intended to allow the removal of values from the default scope (in contrast to #except). However it behaves exactly the same as except: https://gist.github.com/jonleighton/7537008 (other than having a slightly enhanced syntax). The removal of the default scope is allowed by 94924dc32baf78f13e289172534c2e71c9c8cade, which was not a change we could make until 4.1 due to the need to deprecate things. However after that change #unscope still gives us nothing that #except doesn't already give us. However there *is* a desire to be able to unscope stuff in a way that persists across merges, which would allow associations to be defined which unscope stuff from the default scope of the associated model. E.g. has_many :comments, -> { unscope where: :trashed } So that's what this change implements. I've also corrected the documentation. I removed the guide references to #except as I think unscope really supercedes #except now. While we're here, there's also a potential desire to be able to write this: has_many :comments, -> { unscoped } However, it doesn't make sense and would not be straightforward to implement. While with #unscope we're specifying exactly what we want to be removed from the relation, with "unscoped" we're just saying that we want it to not have some things which were added earlier on by the default scope. However in the case of an association, we surely don't want *all* conditions to be removed, otherwise the above would just become "SELECT * FROM comments" with no foreign key constraint. To make the above work, we'd have to somehow tag the relation values which get added when evaluating the default scope in order to differentiate them from other relation values. Which is way too much complexity and therefore not worth it when most use cases can be satisfied with unscope. Closes #10643, #11061.
Diffstat (limited to 'actionview/lib/action_view/helpers/number_helper.rb')
0 files changed, 0 insertions, 0 deletions