diff options
| author | Seb Jacobs <me@sebjacobs.com> | 2019-03-13 17:04:30 +0000 |
|---|---|---|
| committer | Seb Jacobs <me@sebjacobs.com> | 2019-03-15 20:31:24 +0000 |
| commit | 47fea39ed6b01b0f8c440f94e694519ec677ae4c (patch) | |
| tree | df5991035fa4d6756723f90d4a26bf0cba4cd066 /actionview/lib/action_view/helpers/javascript_helper.rb | |
| parent | 1cdc6c6576afe9a9fa67a6b313080a7dc62188d9 (diff) | |
| download | rails-47fea39ed6b01b0f8c440f94e694519ec677ae4c.tar.gz rails-47fea39ed6b01b0f8c440f94e694519ec677ae4c.tar.bz2 rails-47fea39ed6b01b0f8c440f94e694519ec677ae4c.zip | |
Rename `ActionView::Base#run` to `#_run`
There was a recent change by @tenderlove to Action view which introduced
`ActionView::Base#run` [1].
We ran into an issue with our application because one of the core
concepts in our domain model is a `Run` which is exposed in most of our
views as a helper method, which now conflicts with this new method.
Although this is a public method it is not really meant to be part of
the public API.
In order to discourage public use of this method and to reduce the
chances of this method conflicting with helper methods we can prefix
this method with an underscore, renaming this method to `_run`.
[1] https://github.com/rails/rails/commit/c740ebdaf5
Diffstat (limited to 'actionview/lib/action_view/helpers/javascript_helper.rb')
0 files changed, 0 insertions, 0 deletions