diff options
| author | Gaelian Ditchburn <gaelian.ditchburn@gmail.com> | 2012-06-03 19:07:54 +1000 |
|---|---|---|
| committer | Andrew White <andyw@pixeltrix.co.uk> | 2014-01-05 17:16:22 +0000 |
| commit | 7a085dac2a2820856cbe6c2ca8c69779ac766a97 (patch) | |
| tree | 4ef96999eb75ab141666feaf19f2e1546e8e1e5f /actionview/lib/action_view/helpers/form_tag_helper.rb | |
| parent | 6b548830828e4e910de7854d21717c17303e089c (diff) | |
| download | rails-7a085dac2a2820856cbe6c2ca8c69779ac766a97.tar.gz rails-7a085dac2a2820856cbe6c2ca8c69779ac766a97.tar.bz2 rails-7a085dac2a2820856cbe6c2ca8c69779ac766a97.zip | |
Switched to use `display:none` in extra_tags_for_form method.
The use of `display:inline` with the content_tag call in the
extra_tags_for_form method potentially causes display issues with some
browsers, namely Internet Explorer. IE's behaviour of not collapsing
the line height on divs with ostensibly no content means that the
automatically added div containing the hidden authenticity_token, utf8
and _method form input tags may interfere with other visible form
elements in certain circumstances. The use of `display:none` rather
than `display:inline` fixes this problem.
Fixes #6403
Diffstat (limited to 'actionview/lib/action_view/helpers/form_tag_helper.rb')
| -rw-r--r-- | actionview/lib/action_view/helpers/form_tag_helper.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/actionview/lib/action_view/helpers/form_tag_helper.rb b/actionview/lib/action_view/helpers/form_tag_helper.rb index 7ceb56625f..80f066b3be 100644 --- a/actionview/lib/action_view/helpers/form_tag_helper.rb +++ b/actionview/lib/action_view/helpers/form_tag_helper.rb @@ -722,7 +722,7 @@ module ActionView enforce_utf8 = html_options.delete("enforce_utf8") { true } tags = (enforce_utf8 ? utf8_enforcer_tag : ''.html_safe) << method_tag - content_tag(:div, tags, :style => 'margin:0;padding:0;display:inline') + content_tag(:div, tags, :style => 'display:none') end def form_tag_html(html_options) |