aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib/action_view/base.rb
diff options
context:
space:
mode:
authorSeb Jacobs <me@sebjacobs.com>2019-03-13 17:04:30 +0000
committerSeb Jacobs <me@sebjacobs.com>2019-03-15 20:31:24 +0000
commit47fea39ed6b01b0f8c440f94e694519ec677ae4c (patch)
treedf5991035fa4d6756723f90d4a26bf0cba4cd066 /actionview/lib/action_view/base.rb
parent1cdc6c6576afe9a9fa67a6b313080a7dc62188d9 (diff)
downloadrails-47fea39ed6b01b0f8c440f94e694519ec677ae4c.tar.gz
rails-47fea39ed6b01b0f8c440f94e694519ec677ae4c.tar.bz2
rails-47fea39ed6b01b0f8c440f94e694519ec677ae4c.zip
Rename `ActionView::Base#run` to `#_run`
There was a recent change by @tenderlove to Action view which introduced `ActionView::Base#run` [1]. We ran into an issue with our application because one of the core concepts in our domain model is a `Run` which is exposed in most of our views as a helper method, which now conflicts with this new method. Although this is a public method it is not really meant to be part of the public API. In order to discourage public use of this method and to reduce the chances of this method conflicting with helper methods we can prefix this method with an underscore, renaming this method to `_run`. [1] https://github.com/rails/rails/commit/c740ebdaf5
Diffstat (limited to 'actionview/lib/action_view/base.rb')
-rw-r--r--actionview/lib/action_view/base.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/actionview/lib/action_view/base.rb b/actionview/lib/action_view/base.rb
index cf71b4803b..5253ef7b0c 100644
--- a/actionview/lib/action_view/base.rb
+++ b/actionview/lib/action_view/base.rb
@@ -267,7 +267,7 @@ module ActionView #:nodoc:
_prepare_context
end
- def run(method, template, locals, buffer, &block)
+ def _run(method, template, locals, buffer, &block)
_old_output_buffer, _old_virtual_path, _old_template = @output_buffer, @virtual_path, @current_template
@current_template = template
@output_buffer = buffer