diff options
| author | Janko Marohnić <janko.marohnic@gmail.com> | 2019-02-23 23:10:20 +0100 |
|---|---|---|
| committer | Janko Marohnić <janko.marohnic@gmail.com> | 2019-02-23 23:36:58 +0100 |
| commit | 32b2942946edba6a288c6b992109598eeb626964 (patch) | |
| tree | ac6aa4447d664d47e809e3a309425fe8281eac5e /actiontext/test/fixtures | |
| parent | 9118a8f3f89b067b56088409f9f1e99271864a93 (diff) | |
| download | rails-32b2942946edba6a288c6b992109598eeb626964.tar.gz rails-32b2942946edba6a288c6b992109598eeb626964.tar.bz2 rails-32b2942946edba6a288c6b992109598eeb626964.zip | |
Restore UploadedFile compatibility with IO.copy_stream
In https://github.com/rails/rails/pull/28676 the `#to_path` method was
added to `ActionDispatch::Http::UploadedFile`. This broke usage with
`IO.copy_stream`:
source = ActionDispatch::Http::UploadedFile.new(...)
IO.copy_stream(source, destination)
# ~> TypeError: can't convert ActionDispatch::Http::UploadedFile to IO (ActionDispatch::Http::UploadedFile#to_io gives Tempfile)
Normally `IO.copy_stream` just calls `#read` on the source object.
However, when `#to_path` is defined, `IO.copy_stream` calls `#to_io` in
order to retrieve the raw `File` object. In that case it trips up,
because `ActionDispatch::Http::UploadedFile#to_io` returned a `Tempfile`
object, which is not an `IO` subclass.
We fix this by having `#to_io` return an actual `File` object.
Diffstat (limited to 'actiontext/test/fixtures')
0 files changed, 0 insertions, 0 deletions