aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
diff options
context:
space:
mode:
authorschneems <richard.schneeman@gmail.com>2016-01-19 16:22:40 -0600
committerschneems <richard.schneeman@gmail.com>2016-01-19 16:22:40 -0600
commitfe55163f111bb20309f20c4d18959bd6aacb41af (patch)
tree0fbfe2c12b4967857c6048fa45e92859514e42e5 /actionpack
parent12cd2c494d9c6cbec0594b8e63228fda9741e10d (diff)
downloadrails-fe55163f111bb20309f20c4d18959bd6aacb41af.tar.gz
rails-fe55163f111bb20309f20c4d18959bd6aacb41af.tar.bz2
rails-fe55163f111bb20309f20c4d18959bd6aacb41af.zip
Revert "Its ideal to set Vary: Accept-Encoding, irrespective of whether gzipped version exists or not. This is helpful for CDN's to later distinguish assets, based on previous, current copies and introduced gzip version if any."
This reverts commit 067c52f608568e35181830a5c1016e382650e655. Conversation: https://github.com/rails/rails/pull/23120#issuecomment-173007011
Diffstat (limited to 'actionpack')
-rw-r--r--actionpack/lib/action_dispatch/middleware/static.rb2
-rw-r--r--actionpack/test/dispatch/static_test.rb2
2 files changed, 2 insertions, 2 deletions
diff --git a/actionpack/lib/action_dispatch/middleware/static.rb b/actionpack/lib/action_dispatch/middleware/static.rb
index 3eab3795a0..41c220236a 100644
--- a/actionpack/lib/action_dispatch/middleware/static.rb
+++ b/actionpack/lib/action_dispatch/middleware/static.rb
@@ -65,7 +65,7 @@ module ActionDispatch
status, headers, body = @file_server.call(request.env)
end
- headers['Vary'] = 'Accept-Encoding'
+ headers['Vary'] = 'Accept-Encoding' if gzip_path
return [status, headers, body]
ensure
diff --git a/actionpack/test/dispatch/static_test.rb b/actionpack/test/dispatch/static_test.rb
index 24994c8adb..ea8b5e904e 100644
--- a/actionpack/test/dispatch/static_test.rb
+++ b/actionpack/test/dispatch/static_test.rb
@@ -233,7 +233,7 @@ module StaticTests
def assert_html(body, response)
assert_equal body, response.body
assert_equal "text/html", response.headers["Content-Type"]
- assert_not_nil response.headers["Vary"]
+ assert_nil response.headers["Vary"]
end
def get(path, headers = {})