diff options
| author | David Heinemeier Hansson <david@loudthinking.com> | 2005-04-30 08:19:14 +0000 |
|---|---|---|
| committer | David Heinemeier Hansson <david@loudthinking.com> | 2005-04-30 08:19:14 +0000 |
| commit | fe00c275cd1c379af5e4e2a72040febea6b98632 (patch) | |
| tree | 1346cec9cc49eb7a204da072d1e2046b76361616 /actionpack | |
| parent | 8694a79bb2d543a46867454b743c38ce85380e4e (diff) | |
| download | rails-fe00c275cd1c379af5e4e2a72040febea6b98632.tar.gz rails-fe00c275cd1c379af5e4e2a72040febea6b98632.tar.bz2 rails-fe00c275cd1c379af5e4e2a72040febea6b98632.zip | |
Removed dumping of template assigns on the rescue page as it would very easily include a ton of data making page loads take seconds (and the information was rarely helpful) #1222
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
Diffstat (limited to 'actionpack')
| -rw-r--r-- | actionpack/CHANGELOG | 2 | ||||
| -rw-r--r-- | actionpack/lib/action_controller/templates/rescues/_request_and_response.rhtml | 7 |
2 files changed, 2 insertions, 7 deletions
diff --git a/actionpack/CHANGELOG b/actionpack/CHANGELOG index 3f7f3220b0..1c2e54418f 100644 --- a/actionpack/CHANGELOG +++ b/actionpack/CHANGELOG @@ -1,5 +1,7 @@ *SVN* +* Removed dumping of template assigns on the rescue page as it would very easily include a ton of data making page loads take seconds (and the information was rarely helpful) #1222 + * Added BenchmarkHelper that can measure the execution time of a block in a template and reports the result to the log. Example: <% benchmark "Notes section" do %> diff --git a/actionpack/lib/action_controller/templates/rescues/_request_and_response.rhtml b/actionpack/lib/action_controller/templates/rescues/_request_and_response.rhtml index 5f10d91098..d835b8bc9b 100644 --- a/actionpack/lib/action_controller/templates/rescues/_request_and_response.rhtml +++ b/actionpack/lib/action_controller/templates/rescues/_request_and_response.rhtml @@ -33,10 +33,6 @@ request_dump = request_parameters_without_action.inspect.gsub(/,/, ",\n") session_dump = @request.session.instance_variable_get("@data").inspect.gsub(/,/, ",\n") response_dump = @response.inspect.gsub(/,/, ",\n") - - template_assigns = @response.template.instance_variable_get("@assigns") - %w( response exception template session request template_root template_class url ignore_missing_templates logger cookies headers params ).each { |t| template_assigns.delete(t) } - template_dump = template_assigns.inspect.gsub(/,/, ",\n") %> <h2 style="margin-top: 30px">Request</h2> @@ -48,6 +44,3 @@ <h2 style="margin-top: 30px">Response</h2> <b>Headers</b>: <%=h @response.headers.inspect.gsub(/,/, ",\n") %><br/> - -<p><a href="#" onclick="document.getElementById('template_dump').style.display='block'; return false;">Show template parameters</a></p> -<div id="template_dump" style="display:none"><%= debug(template_assigns) %></div> |